Test result attestation#1203
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (7)
WalkthroughThis PR adds attestation publishing and verification steps to GitHub Actions (expanded job permissions, allowlist, and attestation publishing in the test job), renames the source archive to ChangesAttestation Publishing and Verification
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/test.yml:
- Around line 131-137: Add a defensive pre-check before the "Attest test
results" step to verify the subject file exists (subject-path: source.tar.gz)
and fail with a clear message if missing; insert a small run step (e.g., in the
same job, before the actions/attest step) that tests for the presence of
source.tar.gz and exits non‑zero with a descriptive error so the attestation
step is only reached when the artifact file is actually present, ensuring
predicate-path: test-result-predicate.json is only consumed when source.tar.gz
exists.
- Around line 117-129: The predicate currently hardcodes "result": "PASSED" in
the "Generate test result predicate" step and must instead derive the result
explicitly from prior test step outcomes; update the workflow to add an
always()-run step (e.g., a step named "aggregate-test-status" or similar) that
inspects the relevant test steps' outcomes (use each test step's outcomes like
steps.<test-step-id>.outcome or the job status) and sets a build-level
output/variable (e.g., tests_result = "PASSED" or "FAILED") via GITHUB_OUTPUT,
then change the "Generate test result predicate" step to consume that output and
emit test-result-predicate.json with "result": "${{
steps.aggregate-test-status.outputs.tests_result }}" so the attestation reflects
explicit verification rather than a hardcoded value.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: bb7ab6e3-79fc-4d6b-a3e0-3c5d0e05e660
📒 Files selected for processing (5)
.github/workflows/ci.yml.github/workflows/test.ymldoc/howto/verify-integrity.rstdoc/index.rstdoc/tutorials/installation.rst
dc7babc to
1a4f354
Compare
1a4f354 to
ad6759a
Compare
ad6759a to
10ddfa7
Compare
Summary by CodeRabbit
New Features
Documentation
Chores